Code review comment for lp:~mrazik/cupstream2distro-config/mbs-support

Revision history for this message
Francis Ginther (fginther) wrote :

The changes look good, the template changes adequately replace the old dput-mbs-pt jobs. There are some pep8 errors so marking as needs-fixing:
$ pep8 .
./tests/test_cu2dUpdateCi.py:82:63: E231 missing whitespace after ','
./tests/test_cu2dUpdateCi.py:92:63: E231 missing whitespace after ','
./tests/test_cu2dUpdateCi.py:104:63: E231 missing whitespace after ','
./tests/test_cu2dUpdateCi.py:119:63: E231 missing whitespace after ','
./tests/test_cu2dUpdateCi.py:148:63: E231 missing whitespace after ','

This replaces the bulk of the mbs jenkins jobs. The missing piece is the automatic rebuild of downstream dependencies. For example, if a new compiz is built, the old mbs jobs will rebuild unity with the unity-build-mbs-pt job. There is also the *-check-mbs-pt jobs which are used to defer a rebuild if another upstream MP is pending, but these should be removed anyway. If we care about unintended API breakages, we still have some work to do (open a bug for this?).

review: Needs Fixing

« Back to merge proposal