Code review comment for lp:~mr-fiorotto/wingpanel-indicator-sound/trying-to-fix-1591392

Revision history for this message
Danielle Foré (danrabbit) wrote :

When in doubt check the diff. You diff should only contain changes that fall within the scope of solving the issue. In general, please don't change lines that you don't need to. Smaller diffs are easier to review:

* Indicator.vala, Settings.vala, DisplayWidget.vala, MaxWidthLabel.vala, Scale.vala, and Volume-control.vala seem to have been touched unnecessarily. There's no actual change to the code in these files. Please `bzr revert` them.

* MprisClient.vala also looks like you've completely re-written the file. I'm having a tough time seeing what your actual changes are here.

As far as the functionality of the branch, it seems to work as intended. The correct device icon shows and the controls work as expected :)

review: Needs Fixing (code)

« Back to merge proposal