Code review comment for lp:~mr-fiorotto/wingpanel-indicator-notifications/trying-to-fix-
Revision history for this message
| Giuliano Fiorotto (mr-fiorotto) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
> Is the change with removing the "!" intentional? This will make it so that
> even if the action is launched the app will be activated, which in this case,
> should be handeled by the app itself, not the indicator / window manager.
The removal of ! is intentional because, if i'm not wrong, every notification that has default as the specified key for actions should open the app, or should focus it if already opened. No? From gnome specs: "The default action (usually invoked my clicking the notification) should have a key named 'default'. The name can be anything, though implementations are free not to display it." and from what i see, the method run_default_action check if the action is default, then if yes it should activate the program. Please correct me if i'm wrong.