Merge lp:~mpt/reminders-app/1551780-setup into lp:reminders-app

Proposed by Matthew Paul Thomas
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄
Approved revision: 543
Merged at revision: 549
Proposed branch: lp:~mpt/reminders-app/1551780-setup
Merge into: lp:reminders-app
Diff against target: 44 lines (+5/-7)
1 file modified
src/app/qml/Reminders.qml (+5/-7)
To merge this branch: bzr merge lp:~mpt/reminders-app/1551780-setup
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Michael Zanetti (community) Approve
Review via email: mp+287658@code.launchpad.net

Commit message

update some strings

Description of the change

Shortens and copyedits text in the Evernote sync dialog, fixing bug 1551780.

Also changes the dialog buttons:
* “No” to “Not Now”, since you can change your mind later
* red to grey, since a single dialog shouldn't have both green and red buttons
* “Yes” to “Set Up…”, since you have to do something more to set up the account.

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

thanks!

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~mpt/reminders-app/1551780-setup/+merge/287658/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/295/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5646/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/306/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5686/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) :
review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/307/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5687/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/app/qml/Reminders.qml'
--- src/app/qml/Reminders.qml 2015-11-20 11:11:49 +0000
+++ src/app/qml/Reminders.qml 2016-03-01 16:08:15 +0000
@@ -227,7 +227,7 @@
227 switch (accounts.count) {227 switch (accounts.count) {
228 case 0:228 case 0:
229 PopupUtils.open(noAccountDialog, root);229 PopupUtils.open(noAccountDialog, root);
230 print("No account available! Please setup an account in the system settings");230 print("No account available. Please set up an account in System Settings.");
231 break;231 break;
232 case 1:232 case 1:
233 print("Connecting to account", accounts.get(0, "displayName"), "as there is only one account available");233 print("Connecting to account", accounts.get(0, "displayName"), "as there is only one account available");
@@ -711,10 +711,9 @@
711 Dialog {711 Dialog {
712 id: noAccount712 id: noAccount
713 objectName: "noAccountDialog"713 objectName: "noAccountDialog"
714 title: i18n.tr("Setup Evernote connection?")714 title: i18n.tr("Sync with Evernote")
715 text: i18n.tr("Notes can be stored on this device, or optionally synced with Evernote.") + " "715 text: i18n.tr("Notes can be stored on this device, or optionally synced with Evernote.") + " "
716 + i18n.tr("In order to synchronize notes with Evernote, an account at Evernote is required.") + " "716 + i18n.tr("To sync with Evernote, you need an Evernote account.")
717 + i18n.tr("Do you want to setup an account now?")
718717
719 Connections {718 Connections {
720 target: accounts719 target: accounts
@@ -729,8 +728,7 @@
729 RowLayout {728 RowLayout {
730 Button {729 Button {
731 objectName: "openAccountButton"730 objectName: "openAccountButton"
732 text: i18n.tr("No")731 text: i18n.tr("Not Now")
733 color: UbuntuColors.red
734 onClicked: {732 onClicked: {
735 PopupUtils.close(noAccount)733 PopupUtils.close(noAccount)
736 accountService.startAuthentication("@local", null);734 accountService.startAuthentication("@local", null);
@@ -739,7 +737,7 @@
739 }737 }
740 Button {738 Button {
741 objectName: "openAccountButton"739 objectName: "openAccountButton"
742 text: i18n.tr("Yes")740 text: i18n.tr("Set Up…")
743 color: UbuntuColors.green741 color: UbuntuColors.green
744 onClicked: setup.exec()742 onClicked: setup.exec()
745 Layout.fillWidth: true743 Layout.fillWidth: true

Subscribers

People subscribed via source and target branches