Merge lp:~mpt/errors/color-sync-reminders into lp:errors

Proposed by Matthew Paul Thomas
Status: Merged
Merged at revision: 455
Proposed branch: lp:~mpt/errors/color-sync-reminders
Merge into: lp:errors
Diff against target: 41 lines (+9/-0)
3 files modified
errors/api/resources.py (+3/-0)
errors/static/js/most_common_problems.js (+2/-0)
errors/static/js/retracers.js (+4/-0)
To merge this branch: bzr merge lp:~mpt/errors/color-sync-reminders
Reviewer Review Type Date Requested Status
Daisy Pluckers Pending
Review via email: mp+207677@code.launchpad.net

Description of the change

In each of the three places where series colors are defined, adds a reminder to update the other two places.

This is a followup to r450, where Brian had to complete my color changes because I hadn't realized the colors were defined in more than one place.

(In the long run, I guess the colors *should* be defined in one place and imported to the others. This is marked as a TODO in one of the places, but doing it is beyond my ken.)

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'errors/api/resources.py'
2--- errors/api/resources.py 2014-02-19 23:04:45 +0000
3+++ errors/api/resources.py 2014-02-21 15:28:38 +0000
4@@ -32,6 +32,9 @@
5 #release_color_mapping['Ubuntu 14.10'] = '#d9c200'
6 #release_color_mapping['Ubuntu 15.04'] = '#00e600'
7
8+# If you add or change colors here, also update the colors in
9+# static/js/most_common_problems.js and static/js/retracers.js.
10+
11 precise_standards_color_mapping = {
12 'Ubuntu 12.10': '#8edbf4',
13 'Ubuntu 13.04': '#9f8acb',
14
15=== modified file 'errors/static/js/most_common_problems.js'
16--- errors/static/js/most_common_problems.js 2014-02-07 16:31:31 +0000
17+++ errors/static/js/most_common_problems.js 2014-02-21 15:28:38 +0000
18@@ -140,6 +140,8 @@
19
20 var chartFormatter = function(o) {
21 // TODO move this into the CSS by using release classes
22+ // Meanwhile, if you add or change colors here, also update the colors
23+ // in api/resources.py and static/js/retracers.js.
24 var color = '#aea7a0';
25 if (selected_release == 'Ubuntu 12.04') {
26 color = '#29b458';
27
28=== modified file 'errors/static/js/retracers.js'
29--- errors/static/js/retracers.js 2014-02-07 16:31:31 +0000
30+++ errors/static/js/retracers.js 2014-02-21 15:28:38 +0000
31@@ -9,6 +9,10 @@
32 var retrace_data = [];
33 var releases = ['Ubuntu 12.04', 'Ubuntu 12.10', 'Ubuntu 13.04', 'Ubuntu 13.10', 'Ubuntu 14.04'];
34 // 'Ubuntu 14.10', 'Ubuntu 15.04'
35+
36+ // If you add or change colors here, also update the colors
37+ // in api/resources.py and static/js/most_common_problems.js.
38+
39 // two colors (success, failed) for each release
40 var colors = ['#29b458', '#96daab',
41 '#05b8ea', '#8edbf4',

Subscribers

People subscribed via source and target branches