Code review comment for lp:~mpontillo/maas/update-host-maps-cleanup-bug-1440102

Revision history for this message
Raphaƫl Badin (rvb) wrote :

> Note: CI failed with the following errors:
>
> 2015-06-11 18:40:58 ERROR juju.provider.common bootstrap.go:122 bootstrap
> failed: cannot start bootstrap instance: gomaasapi: got error back from
> server: 500 INTERNAL SERVER ERROR ('MAC' object has no attribute 'encode')
> 2015-06-11 18:40:58 INFO juju.cmd cmd.go:113 Bootstrap failed, destroying
> environment
> 2015-06-11 18:40:58 INFO juju.provider.common destroy.go:15 destroying
> environment "maas"
> 2015-06-11 18:41:02 ERROR juju.cmd supercommand.go:323 cannot start bootstrap
> instance: gomaasapi: got error back from server: 500 INTERNAL SERVER ERROR
> ('MAC' object has no attribute 'encode')
>
> I'm looking into this...

I found the problem: CreateHostMaps expects its 'mac_address' parameter(s)to be something that can be converted into unicode (see CreateHostMaps's signature in ps/rpc/cluster.py). But here you're passing the raw MAC (maasserver/fields.py) object instead of passing the mac address as a string. That is because you removed the code http://paste.ubuntu.com/11700836/. I assume the same problem will happen for the IP address.

« Back to merge proposal