Code review comment for lp:~mpontillo/maas/interpret-dhcp-packets-correctly--bug-1628645

Wow this is really large branch. I really just started scrolling quickly at the end because it was so large and I got bored. The code lots good and well tested. The packet creation and parsing is very complicated. It sucks to see all this code being placed in MAAS that we need to maintain when there is already python libraries that do this kind of thing.

I noticed you typed a lot of your methods, but every single one was missing the @typed decorator. You should add that to all the typed methods. I commented on some, but just gave up as I went as it was so large.

Since you have tested this a lot with your router, it can only be an improvement over what it does today. I trusty you!