Code review comment for lp:~mpontillo/maas/interpret-dhcp-packets-correctly--bug-1628645
Revision history for this message
| Mike Pontillo (mpontillo) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f33e652
(Get the code!)
Per your comment inline, I think it would be interesting to see how twisted behaves with a monotonic clock. It's worth trying, but I suppose if any code anywhere assumes it's a UNIX timestamp, it's game over.
This branch is still a work in progress, but today I heavily refactored the code in `detect.py`. In particular, would you give me your thoughts on the `DHCPRequestMon
One thing I tried to do was use @inlineCallbacks to run a generator inside a thread using deferToThread(), but that failed horribly, so I changed the method back to just returning a `set`. Not sure if that's even possible.