Merge ~mpontillo/maas:fix-active-scanning-sudoers--bug-1802379 into maas:master

Proposed by Mike Pontillo
Status: Merged
Approved by: Mike Pontillo
Approved revision: c8f2eca0a7a9d840ec6c440af567d229f7f230f2
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~mpontillo/maas:fix-active-scanning-sudoers--bug-1802379
Merge into: maas:master
Diff against target: 9 lines (+1/-0)
1 file modified
debian/extras/99-maas-common-sudoers (+1/-0)
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
MAAS Lander unittests Pending
Review via email: mp+358740@code.launchpad.net

Commit message

LP: #1802379 - Correct sudoers entry for active network scanning.

Description of the change

For whatever reason (I'm sure this used to work - perhaps due to a security fix, or maybe we changed the sudoers file?) the wildcard argument in the 'sudoers' file no longer allows nothing at all (no parameters) to be specified. We use the lack of parameters in MAAS to mean "all networks".

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) :
review: Needs Information
Revision history for this message
Mike Pontillo (mpontillo) wrote :

See reply inline. Bottom line: I think both are needed.

Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/extras/99-maas-common-sudoers b/debian/extras/99-maas-common-sudoers
2index d701860..47387d2 100644
3--- a/debian/extras/99-maas-common-sudoers
4+++ b/debian/extras/99-maas-common-sudoers
5@@ -43,3 +43,4 @@ maas ALL= NOPASSWD: /usr/lib/maas/maas-write-file
6
7 # Allow active subnet mapping
8 maas ALL= NOPASSWD: /usr/lib/maas/maas-common scan-network *
9+maas ALL= NOPASSWD: /usr/lib/maas/maas-common scan-network

Subscribers

People subscribed via source and target branches