Code review comment for ~mpontillo/maas:default-domain-selection

Revision history for this message
Andres Rodriguez (andreserl) wrote :

I agree!

On Fri, Apr 6, 2018 at 6:04 AM Alberto Donato <email address hidden>
wrote:

> Review: Needs Information
>
> Why do we need an extra model (which ends up having a single instance)
> just to track which is the default domain?
> Can't we add a "default" flag to the domain instead (and have a contraint
> that only allow to have exactly one entry with default=True)?
> We might have a similar case with default user groups and resource pools,
> if we'll want to changing the default. Having to add an extra model seems
> cumbersome
> --
> https://code.launchpad.net/~mpontillo/maas/+git/maas/+merge/342768
> Your team MAAS Committers is subscribed to branch maas:master.
>
> Launchpad-Message-Rationale: Subscriber @maas-committers
> Launchpad-Message-For: maas-committers
> Launchpad-Notification-Type: code-review
> Launchpad-Branch: ~maas-committers/maas/+git/maas:master
> Launchpad-Project: maas
>
--
Andres Rodriguez (RoAkSoAx)
Ubuntu Server Developer
MSc. Telecom & Networking
Systems Engineer

« Back to merge proposal