Code review comment for ~mpontillo/maas:preseed-per-interface-routes--bug-1758919

The change looks good.

One more question about dns.

I see that you have per-interface dns servers, that's rendered correctly for both v2 and v1; however in your netplan output, you don't have any DNS search set, but in v1 you have the global nameserver, which should just be repeated under each interface, so v2:

ethernets:
   eth0:
      nameservers:
         address:
           - 10.0.0.2
         search:
           - maas
   eth1:
      nameservers:
         address:
           - 10.0.1.2
         search:
           - maas

And then in v1:

type: physical
name: eth0
  subnets:
    - type: static
      dns_nameservers:
        - 10.0.0.2
      dns_search:
        - maas
type:physical
name: eth1
  subnets:
    - type: static
      dns_nameservers:
        - 10.0.1.2
      dns_search:
        - maas

That'll complete converting the global types to per-interface types for v1 and v2.