Code review comment for ~mpontillo/maas:remote-script-runner-reliability
Revision history for this message
| Mike Pontillo (mpontillo) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
After looking at `lsof` output, I don't think it's necessary to redirect stdin to DEVNULL; this already seems to happen by default due to the way cloud-init is running and/or how it runs the scripts. But I think we should do it anyway for good measure.
The other change I think we should make to the runner related to bug #1718517 - we should surface any HTTP errors that occur on submit, and we should retry in the case of HTTP 408 or 5xx errors (such as service unavailable, like when Apache is up and running but MAAS is restarting) or timeouts.