Code review comment for ~morphis/snappy-hwe-snaps/+git/network-manager:feature/enable-ethernet-config-item

Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

What I've tried in my rpi3:

Steps:
- install network-manager
- connect interfaces
- snap set network-manager ethernet.enable=true
- verified that
    * 'network-manager.nmcli d' shows eth0 unmanaged
    * 'snap get network-manager ethernet.enable' returns true
    * content in /etc/netplan at this moment is 00-snapd-config.yaml
- reboot
- 'network-manager.nmcli d' shows eth0 connected with connection name as 'netplan-eth0'
- content in /etc/netplan is 00-default-nm-renderer.yaml and 00-snapd-config.yaml

I thinks this is the expected behaviour. My only concern is about leaving other yaml files in /etc/netplan not related with nm. Is that intended?

in this url [1] literally says:

"If you don't want any netplan configuration files being used by NetworkManager, delete all files from /etc/netplan. Any remaining files will be considered by NetworkManager and used to configure Ethernet and wireless network devices"

[1] https://docs.ubuntu.com/core/en/stacks/network/network-manager/docs/enable-ethernet-support

review: Needs Information

« Back to merge proposal