Merge ~morphis/snappy-hwe-snaps/+git/network-manager:feature/ci-finetuning into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master

Proposed by Simon Fels
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 890c2d6d36343173d0c9765ace80d5ff36264758
Merged at revision: 4d86eebc64e02fd81fa664cd555efeaf6a1499b2
Proposed branch: ~morphis/snappy-hwe-snaps/+git/network-manager:feature/ci-finetuning
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master
Diff against target: 50 lines (+16/-1)
3 files modified
spread.yaml (+12/-0)
tests/lib/prepare-all.sh (+2/-0)
tests/main/suspend-resume/task.yaml (+2/-1)
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato Approve
System Enablement Bot continuous-integration Approve
Matteo Croce (community) Approve
Konrad Zapałowicz (community) Approve
Tony Espy Pending
Review via email: mp+316201@code.launchpad.net

Description of the change

Fine tune tests to work better on our CI

 * Use noninteractive front to prevent apt from requiring user input
 * Dump system logs in debug mode for each test case
 * Fine tune the suspend resume test case to work much better

To post a comment you must log in.
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

lgtm

review: Approve
Revision history for this message
Matteo Croce (teknoraver) :
review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/spread.yaml b/spread.yaml
index 93cad8f..83abb24 100644
--- a/spread.yaml
+++ b/spread.yaml
@@ -39,6 +39,18 @@ exclude:
39prepare: |39prepare: |
40 . $TESTSLIB/prepare-all.sh40 . $TESTSLIB/prepare-all.sh
4141
42prepare-each: |
43 # Cleanup logs so we can just dump what has happened in the debug-each
44 # step below after a test case ran.
45 journalctl --rotate
46 sleep .1
47 journalctl --vacuum-time=1ms
48 dmesg -c > /dev/null
49
50debug-each: |
51 journalctl
52 dmesg | grep DENIED || true
53
42# Default is 15 min but we use a higher one here as we build the entire54# Default is 15 min but we use a higher one here as we build the entire
43# network-manager snap inside the global prepare step so we need quite55# network-manager snap inside the global prepare step so we need quite
44# some time. Once we can reuse artifacts from other builds we can change56# some time. Once we can reuse artifacts from other builds we can change
diff --git a/tests/lib/prepare-all.sh b/tests/lib/prepare-all.sh
index 81df7d1..1194d1f 100644
--- a/tests/lib/prepare-all.sh
+++ b/tests/lib/prepare-all.sh
@@ -18,6 +18,8 @@ cat <<-EOF > /home/test/build-snap.sh
18#!/bin/sh18#!/bin/sh
19set -ex19set -ex
2020
21export DEBIAN_FRONTEND=noninteractive
22
21# FIXME: Enable propose for now until problems with conflicting systemd23# FIXME: Enable propose for now until problems with conflicting systemd
22# packages between the Ubuntu Core image ppa and the archive are fixed.24# packages between the Ubuntu Core image ppa and the archive are fixed.
23echo "deb http://archive.ubuntu.com/ubuntu/ xenial-proposed restricted main universe" > /etc/apt/sources.list.d/ubuntu-proposed.list25echo "deb http://archive.ubuntu.com/ubuntu/ xenial-proposed restricted main universe" > /etc/apt/sources.list.d/ubuntu-proposed.list
diff --git a/tests/main/suspend-resume/task.yaml b/tests/main/suspend-resume/task.yaml
index b5df7d1..09cb2cc 100644
--- a/tests/main/suspend-resume/task.yaml
+++ b/tests/main/suspend-resume/task.yaml
@@ -51,7 +51,8 @@ execute: |
51 # Kick off the actual suspend in background so that we can continue51 # Kick off the actual suspend in background so that we can continue
52 # verifying the correct state left by the system before it would52 # verifying the correct state left by the system before it would
53 # normally enter a sleep state.53 # normally enter a sleep state.
54 systemctl suspend --no-block &54 systemctl suspend --no-block || true
55 sleep 1
5556
56 # The easiest way to ensure NetworkManager did the right thing is57 # The easiest way to ensure NetworkManager did the right thing is
57 # by going through its log output and verifying it prints out58 # by going through its log output and verifying it prints out

Subscribers

People subscribed via source and target branches