Code review comment for ~morphis/snappy-hwe-snaps/+git/jenkins-jobs:f/kernel-cross-build-support
Revision history for this message
| Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote | # |
review:
Needs Fixing
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
A couple of inline comments. Also:
1. Please add to the header of "tools/shyaml" the external repo/commit from which it was taken so we cant track the origin an update easily in the future.
2. It would be a good opportunity to clean scripts of shellcheck warnings, see
https:/
and
https:/