Merge ~morphis/snappy-hwe-snaps/+git/engineering-tests:nm-powersave-tests into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

[Simon Fels]

Add tests for WiFi powersave configuration feature

[System Enablement Bot (system-enablement-ci-bot)]

FAILED: Continuous integration, rev:35178de76642f0f4b8bda1a7aeade60f2b398b1d
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/441/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/349/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/441/rebuild

review: Needs Fixing (continuous-integration)

[Jim Hodapp (jhodapp)]

A few comments inline below.

review: Needs Fixing

[Jim Hodapp (jhodapp)]

LGTM

review: Approve (code)

[System Enablement Bot (system-enablement-ci-bot)]

FAILED: Continuous integration, rev:78311ed4e1bf44c3612a7afa20e501d2a73d8355
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/453/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/361/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/453/rebuild

review: Needs Fixing (continuous-integration)

[System Enablement Bot (system-enablement-ci-bot)]

FAILED: Continuous integration, rev:bea0e29233449b8317409e9bf7d2c71cf754b988
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/454/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/362/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/454/rebuild

review: Needs Fixing (continuous-integration)

diff --git a/network-manager/units/wireless.pxu b/network-manager/units/wireless.pxu
 new file mode 100644
index 0000000..704bdd5
--- /dev/null
+++ b/network-manager/units/wireless.pxu
@@ -0,0 +1,59 @@
+# Copyright 2016 Canonical Ltd.
+# All rights reserved.
+#
+# Written by:
+#   Simon Fels <[e-mail]>
+
+unit: category
+id: network_manager
+_name: Network Manager
+
+id: network_manager/wireless/powersave_off_by_default
+category_id: network_manager
+plugin: manual
+_summary: NetworkManager should disable powersave by default
+_purpose:
+ The powersave configuration option should cause the mode on the
+ actual hardware device to be turned off by default.
+_steps:
+ Install wireless-tools snap and check that powersave is turned off
+ on the actual hardware wireless device.
+  $ snap install wireless-tools
+_verification:
+ The iw utility should return the following for the selected wireless device
+  $ sudo wireless-tools.iw dev wlan0 get power_save
+  Power save: off
+
+id: network_manager/wireless/powersave_config_default_off
+category_id: network_manager
+plugin: manual
+_summary:
+ The configuration option should be set to disable by default
+_purpose:
+ On installation the snap sets the option to a default value
+ which should always be the same.
+_steps:
+ Retrieve the configuration value via
+  $ snap get network-manager wifi.powersave
+_verification:
+  The returned value should be "disable".
+
+id: network_manager/wireless/powersave_can_be_enabled
+category_id: network_manager
+plugin: manual
+_summary:
+ Enabling powersave with the configuration option of the snap
+ should turn it on.
+_purpose:
+ The network-manager snap uses a configure hook to control how
+ the WiFi powersave option is set. It should be possible to enable
+ the option on the actual hardware wireless device with it.
+_steps:
+ 1. Enable powersave via the configure hook
+  $ snap set network-manager wifi.powersave=enable
+_verification:
+ Powersave should now be turned on for all wireless devices. This
+ can be verified with
+  $ snap install wireless-tools
+  $ sudo wireless-tools.iw dev wlan0 get power_save
+  Power save: on