Merge ~morphis/snappy-hwe-snaps/+git/alsa-utils:feature/rework-manual-tests into ~snappy-hwe-team/snappy-hwe-snaps/+git/alsa-utils:master

Proposed by Simon Fels
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: c407cd858d281ea3880926c74c0029e53b96322f
Merged at revision: cacd01fb4585930688767accce6d40fc791104b9
Proposed branch: ~morphis/snappy-hwe-snaps/+git/alsa-utils:feature/rework-manual-tests
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/alsa-utils:master
Diff against target: 43 lines (+11/-17)
2 files modified
tests/manual/units/device.pxu (+10/-7)
tests/manual/units/playback.pxu (+1/-10)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve
Alfonso Sanchez-Beato Approve
Review via email: mp+317461@code.launchpad.net

Description of the change

tests: rework tests to be manual instead of automated ones

Somehow the execution of /snap/bin binaries was working before in
devmode was working before but now fails. Converting test cases
to manual ones for the time being.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Please add a bug report to alsa-utils or to the project where the problem might reside, and add a comment in tests/manual/units/device.pxu pointing to that bug.

Besides that, LGTM.

review: Needs Fixing
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) :
review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tests/manual/units/device.pxu b/tests/manual/units/device.pxu
2index 386735a..a3f7b34 100644
3--- a/tests/manual/units/device.pxu
4+++ b/tests/manual/units/device.pxu
5@@ -1,12 +1,15 @@
6+# FIXME: Convert this test back to an automated one. See LP #1665652
7 id: alsa_utils/device/can_list_available_cards
8 category_id: alsa_utils
9 _description:
10 Validate that available ALSA sound cards can be listed with the
11 utilities the snap ships.
12-plugin: shell
13-command:
14- test `/snap/bin/aplay -L | wc -l` -gt 0
15- /snap/bin/amixer | grep Simple
16- /snap/bin/amixer controls | grep CARD
17-estimated_duration: 1s
18-flags: preserve-locale
19+plugin: manual
20+_steps:
21+ Execute the following command:
22+ .
23+ $ /snap/bin/aplay -L
24+ .
25+_verification:
26+ Verify that the command prints out a list of available ALSA
27+ devices.
28diff --git a/tests/manual/units/playback.pxu b/tests/manual/units/playback.pxu
29index d79b0cf..d1a8083 100644
30--- a/tests/manual/units/playback.pxu
31+++ b/tests/manual/units/playback.pxu
32@@ -1,10 +1 @@
33-id: alsa_utils/playback/can_play_wav
34-category_id: alsa_utils
35-_description:
36- Validate we can play a simple wav file we ship as part of the alsa-utils
37- snap.
38-plugin: shell
39-command:
40- /snap/bin/aplay -D hw:1 /snap/alsa-utils/current/usr/share/sounds/alsa/Noise.wav
41-estimated_duration: 1s
42-flags: preserve-locale
43+# FIXME: Convert this test back to an automated one. See LP #1665652

Subscribers

People subscribed via source and target branches

to all changes: