Merge ~morphis/aethercast/+git/aethercast:fix-dhclient-hook into aethercast:master

Proposed by Simon Fels
Status: Approved
Approved by: Simon Fels
Approved revision: 294eee4daebfdcebd17a03cc5017c926328a33e2
Proposed branch: ~morphis/aethercast/+git/aethercast:fix-dhclient-hook
Merge into: aethercast:master
Diff against target: 45 lines (+5/-3)
5 files modified
conf/CMakeLists.txt (+2/-1)
conf/dhclient-hook-p2p (+0/-0)
debian/aethercast.install (+1/-1)
debian/aethercast.maintscript (+1/-0)
debian/usr.sbin.aethercast (+1/-1)
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato Approve
Review via email: mp+310189@code.launchpad.net

Commit message

Fix dhclient hook installation

This was messed up before and is required to correctly not create a default route for DHCP leases gained over P2P for WiFi Display.

Description of the change

Fix dhclient hook installation

This was messed up before and is required to correctly not create a default route for DHCP leases gained over P2P for WiFi Display.

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

5aa83f2... by Simon Fels

Allow dhcpd to write files which just include .lease in the name

dhcpd seems to write some temp files when its creating the lease file
and therefor needs wider access and just *.lease

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) :
review: Approve
294eee4... by Simon Fels

Add maintainer script to get rid of unwanted configuration file

Unmerged commits

294eee4... by Simon Fels

Add maintainer script to get rid of unwanted configuration file

5aa83f2... by Simon Fels

Allow dhcpd to write files which just include .lease in the name

dhcpd seems to write some temp files when its creating the lease file
and therefor needs wider access and just *.lease

cf472e7... by Simon Fels

Correctly install hook for dhclient

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/conf/CMakeLists.txt b/conf/CMakeLists.txt
index 2b346db..274a758 100644
--- a/conf/CMakeLists.txt
+++ b/conf/CMakeLists.txt
@@ -10,4 +10,5 @@ install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/dhcpd.conf
10 DESTINATION /etc/aethercast/)10 DESTINATION /etc/aethercast/)
1111
12install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/dhclient-hook-p2p12install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/dhclient-hook-p2p
13 DESTINATION /etc/dhcp/dhclient-enter-hooks.d/aethercast-p2p)13 RENAME aethercast
14 DESTINATION /etc/dhcp/dhclient-enter-hooks.d/)
diff --git a/conf/dhclient-hook-p2p b/conf/dhclient-hook-p2p
14old mode 10064415old mode 100644
15new mode 10075516new mode 100755
index 242336f..242336f
--- a/conf/dhclient-hook-p2p
+++ b/conf/dhclient-hook-p2p
diff --git a/debian/aethercast.install b/debian/aethercast.install
index 9f6e9b2..3fad47f 100644
--- a/debian/aethercast.install
+++ b/debian/aethercast.install
@@ -4,4 +4,4 @@ usr/bin/aethercastctl
4etc/init/aethercast.conf4etc/init/aethercast.conf
5etc/aethercast/dhcpd.conf5etc/aethercast/dhcpd.conf
6etc/dbus-1/system.d/aethercast-dbus.conf6etc/dbus-1/system.d/aethercast-dbus.conf
7etc/dhcp/dhclient-enter-hooks.d/aethercast-p2p7etc/dhcp/dhclient-enter-hooks.d/aethercast
diff --git a/debian/aethercast.maintscript b/debian/aethercast.maintscript
8new file mode 1006448new file mode 100644
index 0000000..589b6ef
--- /dev/null
+++ b/debian/aethercast.maintscript
@@ -0,0 +1 @@
1rm_conffile /etc/dhcp/dhclient-enter-hooks.d/aethercast-p2p/dhclient-hook-p2p
diff --git a/debian/usr.sbin.aethercast b/debian/usr.sbin.aethercast
index 69fe061..4005900 100644
--- a/debian/usr.sbin.aethercast
+++ b/debian/usr.sbin.aethercast
@@ -11,5 +11,5 @@ capability dac_override,
11/etc/aethercast/dhcpd.conf r,11/etc/aethercast/dhcpd.conf r,
12# In addition aethercast will also point dhcpd to a private12# In addition aethercast will also point dhcpd to a private
13# lease/pid file13# lease/pid file
14/{,var/}run/aethercast/dhcpd*.leases lrw,14/{,var/}run/aethercast/dhcpd*.leases* lrw,
15/{,var/}run/aethercast/dhcpd*.pid lrw,15/{,var/}run/aethercast/dhcpd*.pid lrw,

Subscribers

People subscribed via source and target branches