Code review comment for lp:~moritzm/duplicity/duplicity

Revision history for this message
Kenneth Loafman (kenneth-loafman) wrote :

Since this is a new release and that is a clean solution, I say go for it.
Thanks ede!

On Sun, Oct 19, 2014 at 5:21 AM, edso <email address hidden> wrote:

> how about a similar solution like ssh? we periodically see users having
> issues with paramiko. it's good to have the alternative if the default
> fails for what reason ever.
>
> never came around to do so, because i never needed it, like the patch does
> planned to establish lftp as a ftp backend, although as an alternative one.
> switching would have been done via url scheme eg.
>
> lftp+ftp://
> ncftp+ftp://
>
> while at it i could streamline this switching for ssh as well eg.
>
> paramiko+sftp://
> pexpect+sftp://
>
> retiring the --ssh-backend switch.
>
> what do you guys think? ..ede
>
> On 18.10.2014 22:42, Kenneth Loafman wrote:
> > Let's see if we need to. NcFTP has not been updated in a long time and
> > does not support IPv6. We can always restore the old version.
> >
> >
> > On Sat, Oct 18, 2014 at 3:21 PM, edso <email address hidden> wrote:
> >
> >> On 18.10.2014 21:45, <email address hidden> wrote:
> >>> The proposal to merge lp:~moritzm/duplicity/duplicity into lp:duplicity
> >> has been updated.
> >>>
> >>> Status: Needs review => Merged
> >>>
> >>> For more details, see:
> >>> https://code.launchpad.net/~moritzm/duplicity/duplicity/+merge/238157
> >>>
> >>
> >> i on't like this!.. it removes a perfectly working backend, namely
> ncftp.
> >> can we rather keep both and let the user select which one to choose? i
> >> could live with making lftp the default.
> >>
> >> ..ede
> >>
>
> --
> https://code.launchpad.net/~moritzm/duplicity/duplicity/+merge/238157
> You proposed lp:~moritzm/duplicity/duplicity for merging.
>

« Back to merge proposal