Code review comment for lp:~mordred/glance/conditional-sphinx

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/25/2011 01:41 PM, Rick Harris wrote:
> Review: Needs Fixing Small-nit:
>
> 36 +except:
>
> The unguarded `except` looks a little suspicious, should this be
> `except ImportError` or are there other exceptions here that would be
> considered 'normal'?

Well - normally I'd agree with you. In _this_ case, the idea is that we
want sphinx building to be optional - so if something goes wrong in
setting that up, we'd like to just move on.

I can put in an ImportError: trap though if you'd prefer.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0/WhwACgkQ2Jv7/VK1RgEzvACfZN9jwkvA7gv8R9rNvyopNZRt
40IAoOa7C6ZGIANSEkyqIpoopDnAOSjv
=Ewxf
-----END PGP SIGNATURE-----