Code review comment for lp:~mnordhoff/loggerhead/valid-feed
Revision history for this message
| Matt Nordhoff (mnordhoff) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
This makes the Atom feed valid (bug #247162).
There's still one warning left because the URLs used in the <id>s are URL-encoded, so they're not in the "canonical form". I don't know what should be done, and it's just a warning, so it's probably not vital. Anyway, I'm not making it any *worse*.
At least I fixed all of the outright errors.
"change" objects store only the commit time, in local time, with no time zone information, while Atom feeds need a time + time zone. (See bug #376842.) As a simple, non-invasive and slightly evil solution, I just added a "utc_date" attribute and use UTC time in the feed. There are better fixes available, but it would be more complicated, and dealing with time zones makes my brain hurt, so this is all you're going to get from me any time soon. :P