Code review comment for lp:~mnn282/bzr/sftp-unsupported-operation-more-info

Revision history for this message
mnn (mnn282) wrote :

> Also, having english text as a param prevents that part from being translated, but this isn't too important.
But other exception handling code in SFTPTransport has only english text as parameter too.

> Including the path, and just using the operation name rather than the text form would work for everything but the symlink/rename case, which could just be an optional target_path param to the exception.
This would require altering _translate_io_exception parameters even more.

« Back to merge proposal