Code review comment for lp:~mmcm/akiban-server/parse-boolean

Revision history for this message
Nathan Williams (nwilliams) wrote :

> A column declared BOOLEAN via the adapter will still be
> TINYINT, won't it? So conversions involving this type
> won't apply.

Conversion from string to BOOLEAN, such as WHERE <varchar>. Silly edge case, of course.

The rest of the compatible parse (e.g. 1.asdf = true) is funny, but no need to redo everything right now.

review: Approve

« Back to merge proposal