Code review comment for ~mkukri/ubuntu/+source/zlib:merge

From what I remember 'iii' has just a few roughly coded C programs, that
test s390x optimizations and verify some bugs (that popped up in the past).
(Unfortunately) I assume is not in a shape to be integrated as standard
test - and is s390x specific anyway ... :-/

I more thought about using these as kind of regression testing for the
s390x specific bits and pieces.

But I'll ask - maybe there was some more work on it, that I am not aware of
...

On Tue, Nov 28, 2023 at 4:31 PM Lukas Märdian <email address hidden>
wrote:

> Review: Approve
>
> Thank you Mate, that's indeed a really nice cleanup!
>
> The new patches are nicely structured and provide clean patch headers. I
> confirmed they match the patches from Ilya (iii-i/zlib/dfltcc) on GitHub.
> Besides the new patches the delta looks very similar to our previous delta,
> but this time as clean git-ubuntu commits. Kudos!
>
> @Frank: you mention there might be some test code available, I wonder if
> we could somehow integrate that into the package? Because unfortunately
> there doesn't seem to be any dh_auto_test nor autopkgtest. :(
> Either way, we should definitely ask IBM/Ilya to verify that the new
> patches work as intended.
>
> @Mate: We should also consider upstreaming the d/watch delta to Debian, I
> think that could be useful and doesn't need to be part of the delta.
>
> Test build passed in a PPA:
>
> https://launchpad.net/~mkukri/+archive/ubuntu/dev/+packages?field.name_filter=&field.status_filter=published&field.series_filter=noble
>
> LGTM. Sponsoring.
> --
>
> https://code.launchpad.net/~mkukri/ubuntu/+source/zlib/+git/zlib/+merge/456176
> You are reviewing the proposed merge of ~mkukri/ubuntu/+source/zlib:merge
> into ubuntu/+source/zlib:debian/sid.
>
>