Code review comment for ~mkukri/ubuntu/+source/xserver-xorg-input-synaptics:merge

Hi Mate, thanks for the MP.

I see the changelog says "No change rebuild" but what's going on here is something different. If I diff the actual 1.9.2-1ubuntu1 version to this, it does show differences similar to what is shown in your change description. So this isn't a "No change rebuild" - if you debdiff source package for such an upload I would only expect a difference on debian/changelog. So the changelog should instead reflect that. What's going on here is a correction to a previous flawed upload, which is fine but should be noted in the debian/changelog file. What that should be really depends on the rest of what's going on.

> I know the Debian .diff.gz shouldn't really modify upstream files,
> but the upstream git repo and tarball is not perfectly identical,

Source repacking is a thing and intended for some problems of this sort, for instance if the upstream tarball has things that are believed to be non-distributable. Is that the case here?

> and Debian does the same thing.

It really would be more common to patch these files instead of modifying them directly, even if the Debian version were to be doing it in a non-standard way. Is there a reason we can't patch these files here in the quilt flow?