GTG

Merge lp:~mkevac/gtg/main into lp:~gtg/gtg/old-trunk

Proposed by Marko Kevac
Status: Rejected
Rejected by: Luca Invernizzi
Proposed branch: lp:~mkevac/gtg/main
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~mkevac/gtg/main
Reviewer Review Type Date Requested Status
Luca Invernizzi (community) Needs Resubmitting
Review via email: mp+26473@code.launchpad.net

Commit message

save plugin configuration to file after they are set

Description of the change

Fixing bug https://bugs.launchpad.net/gtg/+bug/578444 by providing config object to Preferences and saving preferences after user closes preferences window.

To post a comment you must log in.
Revision history for this message
Luca Invernizzi (invernizzi) wrote :

Hi Marko!
There is something wrong with the submission of your merge request: the diff against Trunk is 0 lines (you're requesting to merge trunk with trunk, basically).
I checked if this was a Launchpad bug, but apparently it's not.
Could you resubmit?

review: Needs Resubmitting
Revision history for this message
Marko Kevac (mkevac) wrote :

Created new branch and proposed it. Is it ok now?

On Tue, Jun 1, 2010 at 12:27 PM, Luca Invernizzi <email address hidden> wrote:
> Review: Resubmit
> Hi Marko!
> There is something wrong with the submission of your merge request: the diff against Trunk is 0 lines (you're requesting to merge trunk with trunk, basically).
> I checked if this was a Launchpad bug, but apparently it's not.
> Could you resubmit?
> --
> https://code.launchpad.net/~mkevac/gtg/main/+merge/26473
> You are the owner of lp:~mkevac/gtg/main.
>

--
A. Because it breaks the logical sequence of discussion
Q. Why is top posting bad?

Unmerged revisions

781. By Marko Kevac

save plugin configuration to file after they are set

780. By Marko Kevac

save plugin configuration to file after they are set

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to status/vote changes: