Code review comment for lp:~mkanat/loggerhead/view-default

Revision history for this message
Martin Pool (mbp) wrote :

That looks plausible to me, and reasonably clean.

As we discussed elsewhere, it would be good to get this onto the Launchpad deployment branch separately from changes in loggerhead trunk that are possibly more risky, such as historydb.

I wish there was an automatic test included here, but if there is no framework in place I won't ask you to write one as part of this proposal.

review: Approve

« Back to merge proposal