Code review comment for lp:~mkanat/loggerhead/view-default

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Yay for progress on this!

I think it's mostly fine. The template is ugly though. Why do you need to put a None at the end of the annotation iterator? It would be better to pad out the results until you've reached the length of the text lines, or something.

If you're going to rename the annotation css file, you should probably rename the rules therein too.

Everything else looks ok. Loading the annotation information via ajax would be nice, but can wait :-)

Cheers,
mwh

review: Approve

« Back to merge proposal