Code review comment for lp:~mixxxdevelopers/mixxx/features_softtakeover
Revision history for this message
| Sean M. Pappalardo (pegasus-renegadetech) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Dude, you didn't need to quote the whole diff. :P
> 1) How is this useful in its current incarnation if you can't have
> multiple <options> blocks?
The XML soft-takeover option is independent of the MIDI scripting soft-takeover, so it's 100% useable from script now. And any XML controls that currently use the <normal> option can be used with <soft-takeover> right now.
> 2) Why does this have to go in 1.9? None of the mappings are using it. ??
I guess the urgency was from the discussion of ReplayGain auto-adjusting things (which Vittorio might add as an option anyway since I still want it.) But I'm going to update the SCS.1m mapping to use soft-takeover, and the EKS Otus mappings will use it.
> 3) What are the SCS.3d changes you made?
Sorry, that's just whitespace, tabs-to-spaces. (Soft-takeover would be senseless on most touch-only devices.)