Code review comment for lp:~mixxxdevelopers/mixxx/features_m4a_win7_plugin

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

In seek(): If the original setCurrentPosition fails, in other SoundSources I think we generally return the current position (i.e. the current location of the reader) to indicate that the seek failed.

Also, could you define a "const static bool sDebug" at the top of the soundsourcemediafoundation.cpp and then guard all qDebug()'s with that? It could be useful to be able to turn all of those debugs on with a single flag if something needs debugging in the future.

« Back to merge proposal