Code review comment for lp:~mixxxcontributors/mixxx/features_vamp

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hey guys, excellent work here!

A couple of questions before I get down to reviewing this:

* Have any changes been made to lib/vamp or is the source code identical to the VAMP release you have included? For Linux, we will need to depend on the system-installed libvamp-sdk2 package instead of using what's in lib/

* I'm seeing some huge diffs against seemingly unrelated parts of mixxx, e.g. the res/midi and files like plugins/build/osx_m4a_installer.pmdoc/index.xml. It looks like the changes are mostly reformatting. Was this intentional?

* Is FFTW a new dependency? I see it in the configure step. Is that a dependency of VAMP or just a dependency of a VAMP plugin?

« Back to merge proposal