Code review comment for lp:~mixxxcontributors/mixxx/features_vamp

Revision history for this message
RAFFI TEA (raffitea) wrote :

Hey Vittorio,

I really like playing with your branch :-)

I'm not the low-level audio expert and I don't know why the BPM is displayed wrong but I have found some interesting information:

The method BeatMatrix::getBpm() seems to be wrong, There's also a comment within the method stating that. Thanks to you I've played around with "Sonic Visualizer". You're right there are some local variations in the BPM values. For example in "D. Guetta - Sexy Bitch" the local BPM of a position is either 129.2 or 132.5. Building the average of all local BPMs seems to yield the "correct" BPM value as computed by Traktor under a perfect beat grid. Same is valid for all my electronic tracks.

* I used the "tempo and beat tracker: beats" plugin from QM University.

« Back to merge proposal