Code review comment for lp:~mitya57/ubuntu-packaging-guide/translator-credits

Revision history for this message
Daniel Holbach (dholbach) wrote :

Ok, found the bug... it was easily fixed by:

=== modified file 'conf.py'
--- conf.py 2013-02-11 09:22:39 +0000
+++ conf.py 2013-02-19 10:42:03 +0000
@@ -11,7 +11,7 @@
 # All configuration values have a default; values that are commented out
 # serve to show the default.

-import sys, os, re, glob
+import sys, os, re, glob, codecs

 # If extensions (or modules to document with autodoc) are in another directory,
 # add these directories to sys.path here. If the directory is relative to the
@@ -47,7 +47,7 @@

 changelog = "debian/changelog"
 if os.path.exists(changelog):
- head=open(changelog).readline()
+ head=codecs.open(changelog, mode='r', encoding='utf-8').readline()
     match = re.compile(".*\((.*)\).*").match(head)
     if match:
         version = match.group(1)

This was necessary because of "Dražen Lučanin" in debian/changelog. :-)

Pushed the fixed along with yours.

review: Approve

« Back to merge proposal