Code review comment for lp:~mitya57/piston-mini-client/lp1105215

Revision history for this message
Barry Warsaw (barry) wrote :

If we only care about Python 3.3, maybe it's better to catch OSError, since socket.error is a deprecated alias for OSError now, and socket.gaierror is a subclass of OSError. I guess it's not that big of a deal.

review: Approve

« Back to merge proposal