Code review comment for ~mitchdz/ubuntu/+source/tmux:mitch/mantic-clipboard-fix

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote (last edit ):

Thanks, Mitchell.

Noble now has the latest tmux with the fix, so I'm going to review this MP.

I reproduced the issue (thanks for the nice reproducer) and verified that the patch fixes the problem. The SRU text also looks good; this is a very simple fix and I couldn't find much more to comment on the Regression Potential section.

My personal preference is to always list the files that are being change in the changelog entry. This makes it easier to search for specific changes in the future. But as I said, it's a personal preference so I'm fine with keeping the changelog entry as is.

I have a question about the way you backported the patch. Why did you choose to modify an existing patch instead of adding another one on top? This way, you could have added more descriptive headers explaining what the patch is about. If you think it's better to modify the existing patch, then I'd ask you to at least write a comment at the top explaining that you've applied another change on top of it.

Otherwise, this LGTM and is ready to be sponsored as soon as we're clear on the patch situation. Thanks.

review: Needs Information

« Back to merge proposal