Ubuntu
python2.7 package

Code review comment for ~mitchdz/ubuntu/+source/python2.7:mitch/python2.7_flag_opt

  1. Git
  2. lp:~mitchdz/ubuntu/+source/python2.7
  3. mitch/python2.7_flag_opt
  4. Merge into ubuntu/jammy-devel
Revision history for this message
Lena Voytek (lvoytek) wrote :

This patch looks great, and so do the tests. I just have 1 suggestion and a diff comment. Since this is a full patch and not just a simple diff from upstream, I recommend naming it lp2002043-add-optimization-flags-to-cflags.patch rather than lp2002043-add-optimization-flags-to-cflags.diff. That's just a nitpick though and not a necessary change. Overall LGTM, I can sponsor whenever you'd like.

« Back to merge proposal