Ubuntu
landscape-client package

Code review comment for ~mitchburton/ubuntu/+source/landscape-client:2027613-2040189-service-start-fix-mantic

  1. Git
  2. lp:~mitchburton/ubuntu/+source/landscape-client
  3. 2027613-2040189-service-start-fix-mantic
  4. Merge into ubuntu/noble-devel
Revision history for this message
Mitch Burton (mitchburton) wrote :

Pushed latest changes. Summary of what I've changed
- added a revert of the fix for https://bugs.launchpad.net/ubuntu/+source/landscape-client/+bug/2040924
- added a new fix for above, updating d/landscape-sysinfo.wrapper, tested it by executing it as both a regular user and root as per my previous testing for the previous fix
- Added Bug-Ubuntu header items for both patches

re: inline comment about falling back to "/" instead of HOME in patch 0002:
Internally, landscape.lib.user uses pwd (https://docs.python.org/3/library/pwd.html#module-pwd) for script execution to run a script in the run-as user's pw_dir directory, which circumvents HOME. If pw_dir doesn't exist, it defaults to "/".

I'm open to changing that default to something less bad, though. Or maybe first trying to default to HOME, then something else? I was trying to restrict my changes to just test files, though.

« Back to merge proposal