Code review comment for ~mirespace/ubuntu/+source/sysstat:lp-1888345-sysstat-iostat-focal--outputJSONfix

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

We did a session explaining a bit more in detail what was missing.
Thanks bryce for the pre-review we could perfectly use it to go step by step through the "why" these changes are needed.

The version is fixed

The new Deb-3 header is fine, although forwarded is not needed it is also not wrong.

We also went over adding a PPA reference here (done) and added the SRU Template.

Thereby it LGTM now.

review: Approve

« Back to merge proposal