Code review comment for ~mirespace/ubuntu/+source/sysstat:lp-1888345-sysstat-iostat-focal--outputJSONfix

Revision history for this message
Bryce Harrington (bryce) wrote :

Guessing that Christian will be doing the review for this one, but one thing to mention is that when we add patches to a package, our team's standard practice is to add some DEP3 metadata fields.

Here is the template that I use; I suggest saving this locally as you'll be using it often. The referenced link explains what the fields mean.

Description: ...
 ...
Author:
Origin: upstream|backport|vendor|other, https://...
Bug: https://...
Bug-Ubuntu: https://bugs.launchpad.net/bind/+bug/NNNNNN
Bug-Debian: ...
Reviewed-By: ...
Acked-By: ...
Forwarded: no | not-needed | https://salsa.debian.org/....
Applied-Upstream: <release that the fix is expected to be in>, commit:SHA
Last-Update: 2019-06-27

# See https://dep-team.pages.debian.net/deps/dep3/

Christian can give good guidance on what precisely should be included, but for this patch I am guessing at least "Origin", "Bug-Ubuntu:", "Bug:" should be added to the patch, after the "Signed-off-by:" line.

---

One other important note is that when doing SRUs, the version number is always incremented by a decimal fraction. So in this case the version number should be 12.2.0-2ubuntu0.1

---

review: Needs Fixing

« Back to merge proposal