Code review comment for ~mirespace/ubuntu/+source/squid-deb-proxy:sru-focal-squid-deb-proxy-lp1505670-apt-avahi-discover

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Miriam :-). It's looking really great now, so I will sponsor the upload.

Just a very minor detail: we almost always refer to bugs between parentheses in the changelog entry. So in this case, it would be:

  * apt-avahi-discover: write errors to stderr instead
    of stdout so that stdout can be captured correctly.
    Thanks to <email address hidden>. Note that this is
    being fixed differently (stderr and not syslog)
    in the stable releases. (LP: #1505670)

But that's OK and you don't need to worry about it this time :-).

Thanks again.

Uploaded:

$ dput squid-deb-proxy_0.8.15ubuntu0.20.04.1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/squid-deb-proxy/squid-deb-proxy_0.8.15ubuntu0.20.04.1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/squid-deb-proxy/squid-deb-proxy_0.8.15ubuntu0.20.04.1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading squid-deb-proxy_0.8.15ubuntu0.20.04.1.dsc: done.
  Uploading squid-deb-proxy_0.8.15ubuntu0.20.04.1.tar.xz: done.
  Uploading squid-deb-proxy_0.8.15ubuntu0.20.04.1_source.buildinfo: done.
  Uploading squid-deb-proxy_0.8.15ubuntu0.20.04.1_source.changes: done.
Successfully uploaded packages.

review: Approve

« Back to merge proposal