Ubuntu
squid-deb-proxy package

Code review comment for ~mirespace/ubuntu/+source/squid-deb-proxy:sru-focal-squid-deb-proxy-lp1505670-apt-avahi-discover

  1. Git
  2. lp:~mirespace/ubuntu/+source/squid-deb-proxy
  3. sru-focal-squid-deb-proxy-lp1505670-apt-avahi-discover
  4. Merge into ubuntu/focal-devel
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Ah, sorry, I forgot to mention: I have a few comments about the SRU template, specifically the Test Plan section.

I was following it in order to set everything up and try to reproduce the bug & verify the fix, and I noticed that there are a few things missing:

1) After setting up the test-bug1505670-focal VM, it's not clear which packages the user needs to install in order to fully reproduce the issue. ISTR that this information was available before. Would you mind adding it back, please? You need to put it after the "sudo apt update" command.

2) I think the text could also be clearer regarding which commands need to be executed on the host vs. inside the VM. For example, the "apt install apt-cacher-ng" needs to be done on the host.

I think with these improvements the text will look better. Thanks.

« Back to merge proposal