Ubuntu
squid-deb-proxy package

Code review comment for ~mirespace/ubuntu/+source/squid-deb-proxy:sru-hirsute-squid-deb-proxy-lp1505670-apt-avahi-discover

  1. Git
  2. lp:~mirespace/ubuntu/+source/squid-deb-proxy
  3. sru-hirsute-squid-deb-proxy-lp1505670-apt-avahi-discover
  4. Merge into ubuntu/hirsute-devel
Revision history for this message
Miriam España Acebal (mirespace) wrote :

Hi Sergio!

Thank you for your review :).

In fact, I was thinking that those lintian errors were there because it's a sync for now, but I thought about the "boy scout rule" (Always leave the code better than you found it) and more in this case that it's a SRU (and for the older one, Bionic). But better know for sure with your comment that is not strictly necessary.

Definitely yes to the PPA thing. Indeed, I see it when testing an open-vm-tools for Christian and I realized that "it was the way" (great point for the versions conflict hint), but I had the impish ppa for this already and the one for hirsute, so I continued for these bugs with the separates ppa.

After the talk on MM and your steps to reproduce (thanks!):
 - I mixed them with the ones for Christian and I think is now better and clearer I think (I'm afraid, not shorter).
 - On how far to go with the SRUs: I think is related to (or derived better said) the nuance that the conversation took on. Your point looks like very sensate, but I don't see myself in the position to make that decision.

Thanks a lot Sergio!

« Back to merge proposal