Code review comment for ~mirespace/ubuntu/+source/spice:merge-spice-0.14.3-2.1-impish

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

* Changelog:
  - [+] old content and logical tag match as expected
  - [+] changelog entry correct version and targeted codename
  - [-] changelog entries correct

Due to the new indent level the line referring to 973803 is too long now (81 chars)

  - [+] bug references correct (none)
  - [+] update-maintainer has been run

* Merge - Indirect Changes:
  - [+] no upstream changes to consider
  - [-] no further upstream version to consider

There is 0.14.91 but I agree that we will not merge this one now.
It is more a prep to 0.15 than something we'd want so late this cycle

  - [+] debian changes look safe

* Merge - Old Delta:
  - [n/a] dropped changes are ok to be dropped
  - [+] nothing else to drop
  - [n/a] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [+] no new patches added

* Git/Maintenance
  - [+] testcases added or not needed for this
  - [+] commits are properly split (more important on -dev than on SRUs)

* Build/Test:
  - [+] build is ok
  - [+] verified PPA package installs/uninstalls
  - [+] autopkgtest against the PPA package passes (by your tests)

So overall - yeah this LGTM except the little line length issue.
But that should be a quick change and then we can sponsor it.

review: Needs Fixing

« Back to merge proposal