Ubuntu
freeipmi package

Code review comment for ~mirespace/ubuntu/+source/freeipmi:merge-freeipmi_1.6.6-4-impish

  1. Git
  2. lp:~mirespace/ubuntu/+source/freeipmi
  3. merge-freeipmi_1.6.6-4-impish
  4. Merge into ubuntu/devel
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

So this is indeed a sync and I'll sync it after this, but we still can do the review to identify things to improve next time.

1. there was no review slot for anyone else but canonical-server, since reviewing consumes those that isn't enough. You'd usually want to also add one for canonical-server-packageset-reviewers or canonical-server-core-reviewers

2. target branch for a merge from Debian is debian/sid and not as done here ubuntu/devel
   That also explains the odd visualization in the LP preview

3. I checked the build in the PPA
   It is sadly only x86 (you'd usually want all arches we build on the real upload) and
   without proposed configured (so it built with glibc 2.33 instead of the new one).
   The build is good to be done, but the closer you are to the real build on an upload/sync the
   better.

The changelog is a common place for mistakes, but I must say if we would upload (and not sync) this it LGTM - thanks!

+1 to sync this

review: Approve

« Back to merge proposal