Merge ~mirespace/+git/team-subscriptions:mir_libemail-mime-encodings_lp2031487 into ~canonical-server/+git/team-subscriptions:main

Proposed by Miriam España Acebal
Status: Merged
Merge reported by: Miriam España Acebal
Merged at revision: 95e236eec9f152da33d20b306981819ad79f1800
Proposed branch: ~mirespace/+git/team-subscriptions:mir_libemail-mime-encodings_lp2031487
Merge into: ~canonical-server/+git/team-subscriptions:main
Diff against target: 12 lines (+1/-0)
1 file modified
subscriptions.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Canonical Server Reporter Pending
Review via email: mp+450661@code.launchpad.net

Description of the change

Hi team,

package libemail-mime-encodings-perl passed the MIR review and the corresponding bug 2031487
is "Fix commited" status.

The only MIR review's TODO was subscribing the team; therefore I'm proposing this change.

This MIR is part of the libmail-dmarc-perl MIR (bug 2023971), so maybe you prefer to wait for its completion before accept this change, but at least this can help as tracking MP open and "in progress"
in case we decide that is better a unique change for all the packages that will be promoted due to this
spamassassin DMARC feature on.

Thanks in advance.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Yes, I think there's little harm in adding subscriptions early.

Are you able to push to this team repository yourself?

review: Approve
Revision history for this message
Miriam España Acebal (mirespace) wrote :

Hi Bryce, thank you.

Yes, I could do it:

❯ git push git+ssh://<email address hidden>/~canonical-server/+git/team-subscriptions main
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 16 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 352 bytes | 352.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/~canonical-server/+git/team-subscriptions
   77aefaa..95e236e main -> main

Marking the MP as merged too...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/subscriptions.yaml b/subscriptions.yaml
2index b5e183b..fd396ef 100644
3--- a/subscriptions.yaml
4+++ b/subscriptions.yaml
5@@ -98,6 +98,7 @@ ubuntu-server: !!set
6 ? libdbi-drivers
7 ? libdumbnet
8 ? libecap
9+ ? libemail-mime-encodings-perl
10 ? libesmtp
11 ? libfcgi
12 ? libfcgi-perl

Subscribers

People subscribed via source and target branches