Code review comment for lp:~mir-team/qtubuntu/support-state-changing

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Also platform-api has U_MINIMIZED_STATE, why don't you set it there accordingly?

You should ignore Qt::WindowActive. This value is not supported by this method and Qt will never call this method with this value.

Snipped from Qt code:

"""
void QWindow::setWindowState(Qt::WindowState state)
{
    if (state == Qt::WindowActive) {
        qWarning() << "QWindow::setWindowState does not accept Qt::WindowActive";
        return;
    }

    if (d->platformWindow)
        d->platformWindow->setWindowState(state);
"""

« Back to merge proposal