Code review comment for lp:~mir-team/qtmir/server-client-acceptance

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

I've just skimmed through it (so I might very well be wrong), but It all looks as a way to test mir itself and not the interaction between mir and qt, which is what qtmir is all about.

I think the directory structure should match (or at least resemble) what we see in /src. It's "platforms/mirserver" over there, not "qpa". Not saying that "platforms/mirserver" is a good one but I do think src and test should match, so that you can easily find where are the tests for some piece of code and vice-versa.

« Back to merge proposal