Merge lp:~mir-team/qtmir/mir-0.24-compatibility into lp:qtmir

Proposed by Nick Dedekind
Status: Work in progress
Proposed branch: lp:~mir-team/qtmir/mir-0.24-compatibility
Merge into: lp:qtmir
Diff against target: 159 lines (+38/-19)
7 files modified
CMakeLists.txt (+2/-2)
debian/control (+4/-4)
debian/gles-patches/convert-to-gles.patch (+8/-8)
src/platforms/mirserver/screen.cpp (+2/-2)
tests/framework/mock_mir_session.h (+4/-3)
tests/mirserver/WindowManager/stub_session.cpp (+14/-0)
tests/mirserver/WindowManager/stub_session.h (+4/-0)
To merge this branch: bzr merge lp:~mir-team/qtmir/mir-0.24-compatibility
Reviewer Review Type Date Requested Status
Mir development team Pending
Review via email: mp+297292@code.launchpad.net

Commit message

Compatibility with mir-0.24

Description of the change

Compatibility with mir-0.24

To post a comment you must log in.
506. By Nick Dedekind

version bumps

507. By Nick Dedekind

gles

508. By Daniel d'Andrada

Update mir version requirement in CMakeLists.txt

509. By Daniel d'Andrada

Merge trunk

[ Albert Astals Cid ]
* Add support for compiler sanitizers via ECM
* Compile with -fsanitize=undefined
* Fix leak in ScreensModelTest (LP: #1585502)
* Fix leak in SessionManager test (LP: #1585498)
* Remove unused m_sessions member
* Add missing breaks
* Initialize m_lastX and m_lastY
* Initialize m_sessionId
* Give the locker a name
* Fix memory leak in QtEventFeederTest (LP: #1585503)
* Fix leaks in application_manager_test (LP: #1585501)
[ Daniel d'Andrada ]
* Improve Session debug logging
* MirSurfaceListModel: prepending a surface always causes
  firstChanged() emission
[ Gerry Boland ]
* Release temporary GL context ASAP, fixes QtMir on X11. Add some
  hotpath branching hints (LP: #1588921)
[ Michael Zanetti ]
* Adding ApplicationInfo::surfaceCount property

Unmerged revisions

509. By Daniel d'Andrada

Merge trunk

[ Albert Astals Cid ]
* Add support for compiler sanitizers via ECM
* Compile with -fsanitize=undefined
* Fix leak in ScreensModelTest (LP: #1585502)
* Fix leak in SessionManager test (LP: #1585498)
* Remove unused m_sessions member
* Add missing breaks
* Initialize m_lastX and m_lastY
* Initialize m_sessionId
* Give the locker a name
* Fix memory leak in QtEventFeederTest (LP: #1585503)
* Fix leaks in application_manager_test (LP: #1585501)
[ Daniel d'Andrada ]
* Improve Session debug logging
* MirSurfaceListModel: prepending a surface always causes
  firstChanged() emission
[ Gerry Boland ]
* Release temporary GL context ASAP, fixes QtMir on X11. Add some
  hotpath branching hints (LP: #1588921)
[ Michael Zanetti ]
* Adding ApplicationInfo::surfaceCount property

508. By Daniel d'Andrada

Update mir version requirement in CMakeLists.txt

507. By Nick Dedekind

gles

506. By Nick Dedekind

version bumps

505. By Nick Dedekind

mir 0.24 compatibility

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2016-06-14 08:33:42 +0000
+++ CMakeLists.txt 2016-06-28 14:28:03 +0000
@@ -67,8 +67,8 @@
6767
68find_package(Threads REQUIRED)68find_package(Threads REQUIRED)
6969
70pkg_check_modules(MIRSERVER mirserver>=0.22 REQUIRED)70pkg_check_modules(MIRSERVER mirserver>=0.24 REQUIRED)
71pkg_check_modules(MIRCLIENT mirclient>=0.22 REQUIRED)71pkg_check_modules(MIRCLIENT mirclient>=0.24 REQUIRED)
72pkg_check_modules(MIRRENDERERGLDEV mir-renderer-gl-dev>=0.22 REQUIRED)72pkg_check_modules(MIRRENDERERGLDEV mir-renderer-gl-dev>=0.22 REQUIRED)
7373
74pkg_check_modules(XKBCOMMON xkbcommon REQUIRED)74pkg_check_modules(XKBCOMMON xkbcommon REQUIRED)
7575
=== modified file 'debian/control'
--- debian/control 2016-06-03 11:16:30 +0000
+++ debian/control 2016-06-28 14:28:03 +0000
@@ -11,9 +11,9 @@
11 libglib2.0-dev,11 libglib2.0-dev,
12 libgsettings-qt-dev,12 libgsettings-qt-dev,
13 liblttng-ust-dev,13 liblttng-ust-dev,
14 libmirclient-dev (>= 0.22.0),14 libmirclient-dev (>= 0.24.0),
15 libmircommon-dev (>= 0.22.0),15 libmircommon-dev (>= 0.24.0),
16 libmirserver-dev (>= 0.22.0),16 libmirserver-dev (>= 0.24.0),
17 libmtdev-dev,17 libmtdev-dev,
18 libprocess-cpp-dev,18 libprocess-cpp-dev,
19 libqt5sensors5-dev,19 libqt5sensors5-dev,
@@ -26,7 +26,7 @@
26 liburl-dispatcher1-dev,26 liburl-dispatcher1-dev,
27 libxkbcommon-dev,27 libxkbcommon-dev,
28 libxrender-dev,28 libxrender-dev,
29 mir-renderer-gl-dev (>= 0.22.0),29 mir-renderer-gl-dev (>= 0.24.0),
30 pkg-config,30 pkg-config,
31# lttng-gen-ts needs python3, but doesn't depend on it itself: bug 135914731# lttng-gen-ts needs python3, but doesn't depend on it itself: bug 1359147
32 python3:any,32 python3:any,
3333
=== modified file 'debian/gles-patches/convert-to-gles.patch'
--- debian/gles-patches/convert-to-gles.patch 2016-05-18 20:56:14 +0000
+++ debian/gles-patches/convert-to-gles.patch 2016-06-28 14:28:03 +0000
@@ -1,7 +1,7 @@
1Index: inline-gles-quilt/debian/control1Index: qtmir-0.24/debian/control
2===================================================================2===================================================================
3--- inline-gles-quilt.orig/debian/control3--- qtmir-0.24.orig/debian/control
4+++ inline-gles-quilt/debian/control4+++ qtmir-0.24/debian/control
5@@ -1,4 +1,4 @@5@@ -1,4 +1,4 @@
6-Source: qtmir6-Source: qtmir
7+Source: qtmir-gles7+Source: qtmir-gles
@@ -9,7 +9,7 @@
9 Priority: optional9 Priority: optional
10 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>10 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
11@@ -16,7 +16,13 @@ Build-Depends: cmake,11@@ -16,7 +16,13 @@ Build-Depends: cmake,
12 libmirserver-dev (>= 0.19.0),12 libmirserver-dev (>= 0.24.0),
13 libmtdev-dev,13 libmtdev-dev,
14 libprocess-cpp-dev,14 libprocess-cpp-dev,
15+ libqt5gui5-gles,15+ libqt5gui5-gles,
@@ -21,7 +21,7 @@
21+ libqt5test5,21+ libqt5test5,
22 libqtdbusmock1-dev (>= 0.2),22 libqtdbusmock1-dev (>= 0.2),
23 libqtdbustest1-dev (>= 0.2),23 libqtdbustest1-dev (>= 0.2),
24 libubuntu-app-launch2-dev,24 libubuntu-app-launch2-dev (>= 0.9),
25@@ -31,8 +37,8 @@ Build-Depends: cmake,25@@ -31,8 +37,8 @@ Build-Depends: cmake,
26 # lttng-gen-ts needs python3, but doesn't depend on it itself: bug 135914726 # lttng-gen-ts needs python3, but doesn't depend on it itself: bug 1359147
27 python3:any,27 python3:any,
@@ -111,10 +111,10 @@
111- QtMir QPA.111- QtMir QPA.
112+ This variant of the package is for Android-based phones and tablets (built112+ This variant of the package is for Android-based phones and tablets (built
113+ against the OpenGLES variant of qtbase).113+ against the OpenGLES variant of qtbase).
114Index: inline-gles-quilt/debian/rules114Index: qtmir-0.24/debian/rules
115===================================================================115===================================================================
116--- inline-gles-quilt.orig/debian/rules116--- qtmir-0.24.orig/debian/rules
117+++ inline-gles-quilt/debian/rules117+++ qtmir-0.24/debian/rules
118@@ -3,60 +3,28 @@118@@ -3,60 +3,28 @@
119 119
120 export DPKG_GENSYMBOLS_CHECK_LEVEL=4120 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
121121
=== modified file 'src/platforms/mirserver/screen.cpp'
--- src/platforms/mirserver/screen.cpp 2016-05-06 08:41:15 +0000
+++ src/platforms/mirserver/screen.cpp 2016-06-28 14:28:03 +0000
@@ -215,8 +215,8 @@
215 m_type = screen.type;215 m_type = screen.type;
216216
217 // Physical screen size217 // Physical screen size
218 m_physicalSize.setWidth(screen.physical_size_mm.width.as_float());218 m_physicalSize.setWidth(screen.physical_size_mm.width.as_int());
219 m_physicalSize.setHeight(screen.physical_size_mm.height.as_float());219 m_physicalSize.setHeight(screen.physical_size_mm.height.as_int());
220220
221 // Screen capabilities221 // Screen capabilities
222 m_modes = screen.modes;222 m_modes = screen.modes;
223223
=== modified file 'tests/framework/mock_mir_session.h'
--- tests/framework/mock_mir_session.h 2016-04-21 16:21:22 +0000
+++ tests/framework/mock_mir_session.h 2016-06-28 14:28:03 +0000
@@ -65,11 +65,12 @@
65 MOCK_CONST_METHOD1(get_buffer_stream, std::shared_ptr<frontend::BufferStream>(frontend::BufferStreamId));65 MOCK_CONST_METHOD1(get_buffer_stream, std::shared_ptr<frontend::BufferStream>(frontend::BufferStreamId));
66 MOCK_METHOD1(destroy_buffer_stream, void(frontend::BufferStreamId));66 MOCK_METHOD1(destroy_buffer_stream, void(frontend::BufferStreamId));
67 MOCK_METHOD1(create_buffer_stream, frontend::BufferStreamId(graphics::BufferProperties const&));67 MOCK_METHOD1(create_buffer_stream, frontend::BufferStreamId(graphics::BufferProperties const&));
68 void configure_streams(Surface&, std::vector<shell::StreamSpecification> const&) override;;68 void configure_streams(Surface&, std::vector<shell::StreamSpecification> const&) override;
69
70 MOCK_METHOD1(send_input_device_change, void(std::vector<std::shared_ptr<mir::input::Device>> const&));69 MOCK_METHOD1(send_input_device_change, void(std::vector<std::shared_ptr<mir::input::Device>> const&));
71 //void send_input_device_change(std::vector<std::shared_ptr<input::Device>> const& devices) = 0;
7270
71 MOCK_METHOD1(create_buffer, graphics::BufferID(graphics::BufferProperties const&));
72 MOCK_METHOD1(destroy_buffer, void(graphics::BufferID));
73 MOCK_METHOD1(get_buffer, std::shared_ptr<graphics::Buffer>(graphics::BufferID));
7374
74private:75private:
75 std::string m_sessionName;76 std::string m_sessionName;
7677
=== modified file 'tests/mirserver/WindowManager/stub_session.cpp'
--- tests/mirserver/WindowManager/stub_session.cpp 2016-04-21 16:21:22 +0000
+++ tests/mirserver/WindowManager/stub_session.cpp 2016-06-28 14:28:03 +0000
@@ -131,3 +131,17 @@
131void StubSession::send_input_device_change(std::vector<std::shared_ptr<mir::input::Device>> const& /*devices*/)131void StubSession::send_input_device_change(std::vector<std::shared_ptr<mir::input::Device>> const& /*devices*/)
132{132{
133}133}
134
135mir::graphics::BufferID StubSession::create_buffer(const mir::graphics::BufferProperties &)
136{
137 return mir::graphics::BufferID(3);
138}
139
140void StubSession::destroy_buffer(mir::graphics::BufferID)
141{
142}
143
144std::shared_ptr<mir::graphics::Buffer> StubSession::get_buffer(mir::graphics::BufferID)
145{
146 return nullptr;
147}
134148
=== modified file 'tests/mirserver/WindowManager/stub_session.h'
--- tests/mirserver/WindowManager/stub_session.h 2016-04-21 16:21:22 +0000
+++ tests/mirserver/WindowManager/stub_session.h 2016-06-28 14:28:03 +0000
@@ -56,6 +56,10 @@
56 void configure_streams(mir::scene::Surface& surface, std::vector<mir::shell::StreamSpecification> const& config) override;56 void configure_streams(mir::scene::Surface& surface, std::vector<mir::shell::StreamSpecification> const& config) override;
5757
58 void send_input_device_change(std::vector<std::shared_ptr<mir::input::Device>> const& devices) override;58 void send_input_device_change(std::vector<std::shared_ptr<mir::input::Device>> const& devices) override;
59
60 mir::graphics::BufferID create_buffer(mir::graphics::BufferProperties const&) override;
61 void destroy_buffer(mir::graphics::BufferID) override;
62 std::shared_ptr<mir::graphics::Buffer> get_buffer(mir::graphics::BufferID) override;
59};63};
6064
61#endif //QPAMIRSERVER_STUBSESSION_H65#endif //QPAMIRSERVER_STUBSESSION_H

Subscribers

People subscribed via source and target branches