platform-api

Code review comment for lp:~mir-team/platform-api/support-state-changing

  1. support-state-changing
  2. Merge into trunk
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

It's adding duplicate entries to debian/changelog.

---------------

Gotta update debian/libubuntu-application-api2.symbols. Instead of specifying a version put the placeholder "0replaceme" instead. CI will take care of replacing it with the version number being released.

----------------

in CMakeLists.txt:

"""
-set(UBUNTU_PLATFORM_API_VERSION_MINOR 3)
+set(UBUNTU_PLATFORM_API_VERSION_MINOR 5)
"""

Why jumping from 3 to 5 (skipping 4)?

review: Needs Fixing

« Back to merge proposal