Code review comment for lp:~mir-team/platform-api/support-state-changing

Revision history for this message
Gerry Boland (gerboland) wrote :

Need to bump the debian package version number.
Doesn't libubuntu-application-api2.symbols need to have the new symbol added (I expected CI to complain about that)?

Looks ok otherwise.

android/default/default_ubuntu_application_ui.cpp - I don't think this code ever used any more, but maybe a mock implementation needed here? ricmm would know better

review: Needs Fixing

« Back to merge proposal